Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Directory python snippets #3456

Merged
merged 42 commits into from
Jul 24, 2020
Merged

Service Directory python snippets #3456

merged 42 commits into from
Jul 24, 2020

Conversation

rebeccawshaw
Copy link
Contributor

No description provided.

@rebeccawshaw rebeccawshaw requested a review from a team as a code owner April 21, 2020 03:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 23, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 29, 2020

@rebeccawshaw Are you still working on this?

@rebeccawshaw
Copy link
Contributor Author

Ah yes, there hasn’t been any movement on that bug I linked, I’ll try to see if there’s any update!

@tmatsuo
Copy link
Contributor

tmatsuo commented May 15, 2020

@rebeccawshaw I'm closing this. Feel free to re-open when you need this again.

@tmatsuo tmatsuo closed this May 15, 2020
@busunkim96 busunkim96 reopened this Jun 11, 2020
busunkim96 and others added 5 commits June 11, 2020 13:30
@busunkim96
Merge branch 'master' into master
2fc3917
@renovate-bot @leahecole
@busunkim96 @crwilcox
chore(deps): update dependency google-auth-oauthlib to v0.4.1 (Google…
33440b6 
…CloudPlatform#2797)

* chore(deps): update dependency google-auth-oauthlib to v0.4.1

* resolve dependency finding errors

* fix new matplotlib error

Co-authored-by: Leah E. Cole <[email protected]>
Co-authored-by: Leah Cole <[email protected]>
Co-authored-by: Bu Sun Kim <[email protected]>
Co-authored-by: Christopher Wilcox <[email protected]>
@busunkim96
undo accidental changes to translate dir
a954aa7
@busunkim96
chore: remove extra files
a429af0
@busunkim96
remove extra files
300370a
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 11, 2020
@google-cla
Copy link

google-cla bot commented Jul 23, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@leahecole leahecole added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 23, 2020 •
edited
Loading

@rebeccawshaw If you prefer, I can make the lint changes and push it to your branch.

Update:
I created a pull request to your master branch at:
rebeccawshaw#2

If you merge that PR, it will update this PR too.

@leahecole leahecole removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2020
@tmatsuo tmatsuo mentioned this pull request Jul 23, 2020
Closed
@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 23, 2020

@rebeccawshaw

Re: test failures
I think the builds for py-3.7 and py-3.8 are failing because the teardown_module() is deleting all the namespace. I think we should only delete the namespace that the test is using.

@rebeccawshaw
Copy link
Contributor Author

@tmatsuo ah i thought it was like g4 fix, my bad. the spacing is fixed now!

@google-cla
Copy link

google-cla bot commented Jul 24, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jul 24, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jul 24, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 24, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 24, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 24, 2020 •
edited
Loading

@rebeccawshaw Yeah I agree if there's a command like g4 fix, that's great. We'll consider that.

tmatsuo
tmatsuo suggested changes Jul 24, 2020
View reviewed changes
servicedirectory/snippets_test.py Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Jul 24, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jul 24, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 24, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 24, 2020
@tmatsuo tmatsuo merged commit 6e83486 into GoogleCloudPlatform:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@tmatsuo tmatsuo

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rebeccawshaw @tmatsuo @googlebot @busunkim96 @leahecole @kokoro-team @renovate-bot